Add icon attribution in aria-details #815
Open
+15
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at using the already in-scope license info to add attribution to Icon components.
Example reference from fontawesome when you download an svg from their website:
Also looked into using HTML comments but that requires using dangerouslySetInnerHTML or refs, and conflicts with using children.
Very open to discussion and suggestions. Builds from pipelines dont seem to reflect any changes so i'm a little confused.